core.match clojurescript should be self-host compatible
Description
Environment
Attachments
- 23 Oct 2016, 03:21 PM
Activity
Alex Miller January 17, 2017 at 4:06 PM
@Yehonathan Sharvit please see Christophe's comments. I'd be happy to help shepherd this into a release if others could get to a point where it has a patch that works on Clojure, ClojureScript, and self-hosted ClojureScript.
Christophe Grand January 3, 2017 at 1:21 PM
If the goal of this patch is only to make cljs.core.match self-host compatible (and not to also unify cljs.core.match and clojure.core.match) then I think there are several references to clojure that shouldn't be there and I also think that backtrack-expr and FailureNode emit clojure code instead of clojurescript code when run in clojure-compiled clojurescript.
Alex Miller December 6, 2016 at 4:18 PM
The other question is whether we want to require Clojure 1.7 as a dependency for core.match, which means removing a lot of older versions from support. I think I'm ok with that, but would like to hear more from community too.
Yehonathan Sharvit December 6, 2016 at 1:06 PM
Now that cljc is fully supported, could someone take a look at this patch? Alex? David?
Yehonathan Sharvit October 27, 2016 at 2:55 PM
Anyway, I'd be happy to get feedback on my patch.
It's a lot of code dealing with the differences between cljs and clojure types.
core.match clojurescript should be self-host compatible