Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

Outdated dependencies

Description

The Clojure version specified in core is 1.6, which is lower than the minimum supported version in CIDER (1.7)
The Clojurescript version is "0.0-2496" which seems rather outdated compared to the current "1.9.293"
The lein-cljsbuild is "1.0.4-snapshot" instead of current 1.1.4

Rather critically, this specifies its own version of cider-nrepl, a very out of date 0.8.1, rather than letting CIDER inject its current version (stable 0.14 or dev 0.15). These happen automatically now depending upon the version of CIDER you are running.

this just updates these versions in the project.clj file.

Environment

Emacs 25, CIDER

Attachments

2
  • 17 May 2019, 09:22 PM
  • 05 Dec 2016, 01:22 PM

Activity

Show:

import May 17, 2019 at 9:23 PM

Add last version of attachment lost in import.

Alex Miller December 16, 2016 at 5:38 PM

The lib is not in control of what version of Clojure it is used with - that's up to the user.

Pegging it to a lower version here (lowest supported) means that we are aware if the code starts using something newer (because of breakage). I don't know of any reason this project should not support back to Clojure 1.6.

As a separate issue, the project.clj file is helpful for dev (and cljs), but is not actually used when building or deploying the project - that's all controlled via the Maven pom.xml. So all dependency changes made in the project.clj dependencies also need to be mirrored in the pom.xml file.

Daniel Sutton December 7, 2016 at 4:25 PM

I was under the impression that the lib would use whatever versions of Clojure were in the project that loaded the lib. So updating the project.clj file affected development only. If this is incorrect I'd certainly agree with you.

CIDER doesn't officially support below 1.7 and prints a repl warning stating that nrepl and CIDER might have communication issues.

Alex Miller December 6, 2016 at 4:04 PM

Generally we try to maintain the lowest possible minimum requirement for Clojure so that the lib can be used by as wide a group of users as possible. afaict, you don't need any new features in Clojure 1.7 or 1.8 and there is no reason to update this minimum version. You can still use it with CIDER, so that seems like a non-argument.

Daniel Sutton December 5, 2016 at 1:23 PM

Patch added with `[org.clojure/tools.analyzer.jvm "0.6.10"]`

Details

Assignee

Reporter

Labels

Patch

Code

Priority

Created December 2, 2016 at 6:23 PM
Updated May 17, 2019 at 9:23 PM

Flag notifications