core.match

Outdated dependencies

Details

  • Type: Defect Defect
  • Status: Open Open
  • Priority: Minor Minor
  • Resolution: Unresolved
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
  • Environment:
    Emacs 25, CIDER
  • Patch:
    Code

Description

The Clojure version specified in core is 1.6, which is lower than the minimum supported version in CIDER (1.7)
The Clojurescript version is "0.0-2496" which seems rather outdated compared to the current "1.9.293"
The lein-cljsbuild is "1.0.4-snapshot" instead of current 1.1.4

Rather critically, this specifies its own version of cider-nrepl, a very out of date 0.8.1, rather than letting CIDER inject its current version (stable 0.14 or dev 0.15). These happen automatically now depending upon the version of CIDER you are running.

this just updates these versions in the project.clj file.

Activity

Hide
Enzzo Cavallo added a comment -

Please, bump tools.analyzer.jvm too.

[org.clojure/tools.analyzer.jvm "0.6.10"]

Show
Enzzo Cavallo added a comment - Please, bump tools.analyzer.jvm too. [org.clojure/tools.analyzer.jvm "0.6.10"]
Hide
daniel sutton added a comment -

Patch added with `[org.clojure/tools.analyzer.jvm "0.6.10"]`

Show
daniel sutton added a comment - Patch added with `[org.clojure/tools.analyzer.jvm "0.6.10"]`
Hide
Alex Miller added a comment -

Generally we try to maintain the lowest possible minimum requirement for Clojure so that the lib can be used by as wide a group of users as possible. afaict, you don't need any new features in Clojure 1.7 or 1.8 and there is no reason to update this minimum version. You can still use it with CIDER, so that seems like a non-argument.

Show
Alex Miller added a comment - Generally we try to maintain the lowest possible minimum requirement for Clojure so that the lib can be used by as wide a group of users as possible. afaict, you don't need any new features in Clojure 1.7 or 1.8 and there is no reason to update this minimum version. You can still use it with CIDER, so that seems like a non-argument.
Hide
daniel sutton added a comment -

I was under the impression that the lib would use whatever versions of Clojure were in the project that loaded the lib. So updating the project.clj file affected development only. If this is incorrect I'd certainly agree with you.

CIDER doesn't officially support below 1.7 and prints a repl warning stating that nrepl and CIDER might have communication issues.

Show
daniel sutton added a comment - I was under the impression that the lib would use whatever versions of Clojure were in the project that loaded the lib. So updating the project.clj file affected development only. If this is incorrect I'd certainly agree with you. CIDER doesn't officially support below 1.7 and prints a repl warning stating that nrepl and CIDER might have communication issues.
Hide
Alex Miller added a comment -

The lib is not in control of what version of Clojure it is used with - that's up to the user.

Pegging it to a lower version here (lowest supported) means that we are aware if the code starts using something newer (because of breakage). I don't know of any reason this project should not support back to Clojure 1.6.

As a separate issue, the project.clj file is helpful for dev (and cljs), but is not actually used when building or deploying the project - that's all controlled via the Maven pom.xml. So all dependency changes made in the project.clj dependencies also need to be mirrored in the pom.xml file.

Show
Alex Miller added a comment - The lib is not in control of what version of Clojure it is used with - that's up to the user. Pegging it to a lower version here (lowest supported) means that we are aware if the code starts using something newer (because of breakage). I don't know of any reason this project should not support back to Clojure 1.6. As a separate issue, the project.clj file is helpful for dev (and cljs), but is not actually used when building or deploying the project - that's all controlled via the Maven pom.xml. So all dependency changes made in the project.clj dependencies also need to be mirrored in the pom.xml file.

People

Vote (0)
Watch (0)

Dates

  • Created:
    Updated: