test.check

Convert to .cljc

Details

  • Type: Enhancement Enhancement
  • Status: Resolved Resolved
  • Priority: Major Major
  • Resolution: Completed
  • Affects Version/s: None
  • Fix Version/s: None
  • Component/s: None
  • Labels:
    None

Description

There are separate patches for each namespace, numbered in the order that they should be applied.

  1. 10-generators-ns.patch
    11/Sep/15 9:46 AM
    73 kB
    Nicolás Berger
  2. 1-move-cljs-tests-to-clojure.patch
    10/Sep/15 8:57 PM
    56 kB
    Nicolás Berger
  3. 2-upgrade-cljsbuild.patch
    10/Sep/15 8:57 PM
    0.7 kB
    Nicolás Berger
  4. 3-clojure-test-ns.patch
    10/Sep/15 8:57 PM
    30 kB
    Nicolás Berger
  5. 4-clojure-test-check-ns.patch
    10/Sep/15 10:21 PM
    20 kB
    Nicolás Berger
  6. 4-clojure-test-check-ns-with-header.patch
    19/Sep/15 4:25 PM
    20 kB
    Nicolás Berger
  7. 5-clojure-test-check-test-ns.patch
    10/Sep/15 10:21 PM
    65 kB
    Nicolás Berger
  8. 6-rose-tree-ns.patch
    10/Sep/15 11:08 PM
    21 kB
    Nicolás Berger
  9. 7-properties-ns.patch
    10/Sep/15 11:08 PM
    6 kB
    Nicolás Berger
  10. 8-not-import-pseudorandom.patch
    11/Sep/15 9:46 AM
    0.9 kB
    Nicolás Berger
  11. 9-remove-random-states-fn.patch
    11/Sep/15 9:46 AM
    1.0 kB
    Nicolás Berger

Activity

Hide
Nicolás Berger added a comment -

Except for the namespaces related to RNG, all the namespaces have been converted.

Tests are green both in clj and cljs.

Namespaces related to RNG are so different from clj to cljs that I don't think they should be converted to cljc.

Show
Nicolás Berger added a comment - Except for the namespaces related to RNG, all the namespaces have been converted. Tests are green both in clj and cljs. Namespaces related to RNG are so different from clj to cljs that I don't think they should be converted to cljc.
Hide
Gary Fredericks added a comment -

I've applied the first three patches, thanks.

The fourth one introduces a new namespace – could you paste in the header from one of the other files?

Show
Gary Fredericks added a comment - I've applied the first three patches, thanks. The fourth one introduces a new namespace – could you paste in the header from one of the other files?
Hide
Nicolás Berger added a comment -

Sorry, I don't get what's the issue with the new namespace in the patch. Is it something about the following header?

diff --git a/src/main/clojure/clojure/test/check/impl.cljc b/src/main/clojure/clojure/test/check/impl.cljc
new file mode 100644
index 0000000..9bdcad4
— /dev/null
+++ b/src/main/clojure/clojure/test/check/impl.cljc

I tried with git am --keep-cr -s --ignore-whitespace < 4-clojure-test-check-ns.patch and it works fine. Is that what you are running?

Show
Nicolás Berger added a comment - Sorry, I don't get what's the issue with the new namespace in the patch. Is it something about the following header?
diff --git a/src/main/clojure/clojure/test/check/impl.cljc b/src/main/clojure/clojure/test/check/impl.cljc new file mode 100644 index 0000000..9bdcad4 — /dev/null +++ b/src/main/clojure/clojure/test/check/impl.cljc
I tried with git am --keep-cr -s --ignore-whitespace < 4-clojure-test-check-ns.patch and it works fine. Is that what you are running?
Hide
Gary Fredericks added a comment -

I'm talking about the comment at the top of each test.check source file:

;   Copyright (c) Rich Hickey, Reid Draper, and contributors.
;   All rights reserved.
;   The use and distribution terms for this software are covered by the
;   Eclipse Public License 1.0 (http://opensource.org/licenses/eclipse-1.0.php)
;   which can be found in the file epl-v10.html at the root of this distribution.
;   By using this software in any fashion, you are agreeing to be bound by
;   the terms of this license.
;   You must not remove this notice, or any other, from this software.

Show
Gary Fredericks added a comment - I'm talking about the comment at the top of each test.check source file:
;   Copyright (c) Rich Hickey, Reid Draper, and contributors.
;   All rights reserved.
;   The use and distribution terms for this software are covered by the
;   Eclipse Public License 1.0 (http://opensource.org/licenses/eclipse-1.0.php)
;   which can be found in the file epl-v10.html at the root of this distribution.
;   By using this software in any fashion, you are agreeing to be bound by
;   the terms of this license.
;   You must not remove this notice, or any other, from this software.

Hide
Nicolás Berger added a comment -

Oh, that header. Sorry, didn't see it. Will upload a new patch in a minute

Show
Nicolás Berger added a comment - Oh, that header. Sorry, didn't see it. Will upload a new patch in a minute
Hide
Nicolás Berger added a comment -

Added new version of patch 4 as 4-clojure-test-check-ns-with-header.patch, now including the license header

Show
Nicolás Berger added a comment - Added new version of patch 4 as 4-clojure-test-check-ns-with-header.patch, now including the license header
Hide
Gary Fredericks added a comment -

These have all been applied on master; thanks!

Show
Gary Fredericks added a comment - These have all been applied on master; thanks!

People

Vote (0)
Watch (1)

Dates

  • Created:
    Updated:
    Resolved: