Skip to:

  1. Skip to Jira Navigation
  2. Skip to Side Navigation
  3. Skip to Main Content

JS module support: Properly convert UMD pattern

Description

Many popular libraries use the following or a similar idiom:

The ProcessCommonJSModules class converts this to the following:

module will not be defined, so the greeting object will not be assigned to the new module namespace. We need to check with the Google Closure compiler mailing list if we can submit a patch that replaces module so that the condition succeeds.

Environment

None

Activity

Show:

Maria Geller August 13, 2015 at 7:49 PM

This has been merged into the Google Closure compiler and seems to work: https://github.com/google/closure-compiler/commit/aa0a99cf380b05b2185156735d023b6fa78ec4ac

Should be good to close now

Maria Geller July 23, 2015 at 2:52 AM

Maria Geller June 15, 2015 at 7:35 PM

Asked about this on Google Closure compiler mailing list: https://groups.google.com/forum/#!topic/closure-compiler-discuss/-M1HBUn35fs

Completed

Details

Assignee

Reporter

Fix versions

Affects versions

Priority

Created June 15, 2015 at 6:07 PM
Updated August 15, 2015 at 1:50 AM
Resolved August 15, 2015 at 1:50 AM
Loading...