tools.deps pom generation not including groupId for exclusions that have no separate groupId

Description

A deps entry such as:

jsr310-tagged-literals {:mvn/version "0.1.4" :exclusions [cljs.java-time]}

is generated as

<dependency>
<groupId>jsr310-tagged-literals</groupId>
<artifactId>jsr310-tagged-literals</artifactId>
<version>0.1.4</version>
<exclusions>
<exclusion>
<groupId/></groupId>
<artifactId>cljs.java-time</artifactId>
</exclusion>
</exclusions>
</dependency>

which is inconsistent with how a dependency on e.g. cljs.java-time appears, because in that case the groupId is filled in as cljs.java-time.

This issue was noticed because clj -Stree fails when reading such a pom, with an error '/cljs.java-time is not a valid symbol'

Environment

None

Activity

Show:

Alex Miller January 2, 2019 at 7:12 PM

Released in tools.deps.alpha 0.6.474

Alex Miller November 20, 2018 at 7:01 PM

Well, don't get too excited - not sure how long it will be before I get it in a release.

Henry Widd November 20, 2018 at 6:57 PM

wow, superfast! cheers

Completed

Details

Assignee

Reporter

Priority

Created November 20, 2018 at 6:31 PM
Updated January 2, 2019 at 7:12 PM
Resolved January 2, 2019 at 7:12 PM

Flag notifications