exclusions are not reflected to pom.xml

Description

Context

I'd like to leverage mvn dependency:tree plugin to figure out the conflicts in transitive dependencies, as clj currently doesn't provide a feature equivalent to lein deps :tree.

Problem

pom.xml generated by clj -Spom doesn't convey exclusions defined in deps.edn. Here is a snippet of pom.xml
generated in tools.deps project itself.

deps.edn

{:deps {
  ...
   org.apache.maven/maven-aether-provider
   {:mvn/version "3.3.9"
    :exclusions [org.eclipse.aether/aether-api org.eclipse.aether/aether-spi
                 org.eclipse.aether/aether-util org.eclips.aether/aether-impl]}
   ...}}

pom.xml

...
    <dependency>
      <groupId>org.apache.maven</groupId>
      <artifactId>maven-aether-provider</artifactId>
      <version>3.3.9</version>
    </dependency>
...

I expect dependency exclusion directive is generated in <dependency> tag.

...
    <dependency>
      <groupId>org.apache.maven</groupId>
      <artifactId>maven-aether-provider</artifactId>
      <version>3.3.9</version>
      <exclusions>
        <exclusion>
          <groupId>org.eclipse.aether</groupId>
          <artifactId>aether-api</artifactId>
        </exclusion>
        <exclusion>
          <groupId>org.eclipse.aether</groupId>
          <artifactId>aether-spi</artifactId>
        </exclusion>
        <exclusion>
          <groupId>org.eclipse.aether</groupId>
          <artifactId>aether-util</artifactId>
        </exclusion>
        <exclusion>
          <groupId>org.eclipse.aether</groupId>
          <artifactId>aether-impl</artifactId>
        </exclusion>
      </exclusions>
    </dependency>
...

Environment

clojure-tools-1.9.0.297

Activity

Show:

Alex MillerJanuary 18, 2018 at 10:48 PM

Committed for next release

Alex MillerJanuary 18, 2018 at 10:29 PM

I'll take care of it, no biggie.

importJanuary 18, 2018 at 10:28 PM

Comment made by: k2n

I was confused with the original pom.xml checked in the repo. Yes, my original observation is valid even in 302. Please take a look at it when you have a chance, or let me know if you want me to create a PR.

Alex MillerJanuary 18, 2018 at 10:22 PM

I don't think it has actually. There is no code to emit exclusions in the pom (yet).

importJanuary 18, 2018 at 10:19 PM

Comment made by: k2n

Noticed it has been fixed in 1.9.0.302. Please close this ticket.

Completed

Details
Assignee
Alex Miller
Reporter
import
Priority
Major

Created January 18, 2018 at 10:13 PM

Updated January 19, 2018 at 12:58 PM

Resolved January 19, 2018 at 12:58 PM