<< Back to previous view

[ASYNC-109] Clarify timeout doc to mention that close! should not be called on a timeout channel Created: 11/Dec/14  Updated: 19/Nov/18

Status: Open
Project: core.async
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Ryan Neufeld Assignee: Unassigned
Resolution: Unresolved Votes: 4
Labels: docstring, documentation

Attachments: Text File clarify-timeout-doc.patch    
Patch: Code


After running into a race-condition involving closed timeout channels, it seems like it would be appropriate to mention that `close!` should never be called on a timeout channel in its docstring. The attached patch tweaks the doc string to that effect. Please advise if you'd like the wording changed a bit.

Comment by Howard Lewis Ship [ 12/Dec/14 11:03 AM ]

Alternately/additionally, it would be nice if close! on a timeout channel would throw an exception.

Comment by Erik Assum [ 30/Dec/14 8:25 AM ]

or alternately, make it a no-op?

Comment by Alex Miller [ 19/Nov/18 2:34 PM ]

Yeah, I think it would be better to fix this than doc it.

Generated at Sun May 19 09:44:18 CDT 2019 using JIRA 4.4#649-r158309.