<< Back to previous view

[CLJ-1109] Oracle Java 5 fails to run tests when building Clojure Created: 19/Nov/12  Updated: 15/Dec/12  Resolved: 15/Dec/12

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: Release 1.5
Fix Version/s: None

Type: Defect Priority: Trivial
Reporter: Andy Fingerhut Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Oracle Java 1.5.0_22, at least

Attachments: Text File patch-enable-java-5-to-pass-tests-v1.txt    
Patch: Code and Test


This is due to the way that reducers.clj currently handles the ForkJoin library.

Comment by Andy Fingerhut [ 19/Nov/12 3:50 PM ]

Patch patch-enable-java-5-to-pass-tests-v1.txt dated Nov 19 2012 enables at least Oracle Java 1.5.0_22 to build and pass all tests in latest master.

No, tt doesn't implement a ForkJoin library. It simply declares some Clojure fj functions to throw an exception if they are called. In today's Clojure tests they never are.

Comment by Andy Fingerhut [ 20/Nov/12 3:45 PM ]

Updated patch with proper name and email address.

Comment by Timothy Baldridge [ 30/Nov/12 3:05 PM ]

IMO, more tests are always good. Vetted.

Comment by Rich Hickey [ 15/Dec/12 7:33 AM ]

This is the wrong approach to this problem. A better approach is to make reducers work even if no fj support is present by simply defining fold as sequential reduce in that case.

Generated at Mon Oct 23 06:50:20 CDT 2017 using JIRA 4.4#649-r158309.