<< Back to previous view

[CLJ-1329] Unused local variable in PersistentVector.cons() Created: 22/Jan/14  Updated: 12/Oct/15  Resolved: 12/Oct/15

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: Release 1.5, Release 1.6
Fix Version/s: Release 1.8

Type: Enhancement Priority: Trivial
Reporter: Smit Shah Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: collections, ft

Attachments: Text File clj-1329-2.patch     Text File fix.patch    
Patch: Code
Approval: Ok


in src/jvm/clojure/lang/PersistentVector.java:168, there is an integer i being defined which is not being used anywhere in the method.

Patch: clj-1329-2.patch
Screened by: Alex Miller

Comment by Stuart Halloway [ 31/Jan/14 6:14 PM ]

Smit, can you please submit a CA? http://clojure.org/contributing

Comment by Smit Shah [ 02/Feb/14 1:16 PM ]

Stuart, I will send the CA via post ASAP.
It might take a couple of days to reach Rich though.

Comment by Smit Shah [ 01/Mar/14 11:51 AM ]

Stuart, I have successfully submitted the CA (http://clojure.org/contributing).
I guess now merging this patch shouldn't be a problem

Comment by Alex Miller [ 02/Mar/14 11:37 AM ]

Thanks Smit!

Comment by Andy Fingerhut [ 01/Oct/14 6:43 PM ]

Smit, instructions for creating a patch in the format expected by the screeners is given on the wiki page below. The one you have attached is not in the expected format.


Comment by Alex Miller [ 29/Apr/15 2:28 PM ]

Added new patch - same diff but proper format

Generated at Sun Jan 21 07:05:48 CST 2018 using JIRA 4.4#649-r158309.