[CLJ-1398] Update URLs in javadoc.clj Created: 02/Apr/14 Updated: 06/Sep/17 Resolved: 06/Sep/17
|Affects Version/s:||Release 1.7, Release 1.8|
|Fix Version/s:||Release 1.9|
|Attachments:||0001-update-apache-commons-javadoc-location.patch 0002-add-javadoc-lookup-for-guava-and-apache-commons-lang.patch 0003-add-javadoc-lookup-for-jdk8.patch clj-1398.patch|
javadoc.clj contains javadoc base urls for the jdk and several popular open source libraries. Most of these urls are broken.
For example, create a project with the following dependencies:
And then try the following javadoc checks:
|Comment by Andy Fingerhut [ 04/Apr/14 11:22 AM ]|
Eli, thanks for the patches. It appears that you are not currently on the list of Clojure contributors here: http://clojure.org/contributing
It is the policy of the Clojure team only to incorporate patches submitted by people who have signed and submitted a Clojure CA. Were you interested in doing that?
|Comment by Eli Lindsey [ 04/Apr/14 11:27 AM ]|
> It is the policy of the Clojure team only to incorporate patches submitted by people who have signed and submitted a Clojure CA. Were you interested in doing that?
Yup! I mailed off the CA to Rich on Wednesday when this was filed; should be arriving shortly.
|Comment by Eli Lindsey [ 09/May/14 8:18 PM ]|
Just to note - Clojure CA went through and I'm listed on the contributors page now.
|Comment by Alex Miller [ 01/Feb/16 6:15 AM ]|
I squashed the patches and made some minor modifications in the jdk urls. Patch attribution retained.
|Comment by Bozhidar Batsov [ 08/Mar/16 3:15 PM ]|
|Comment by Alex Miller [ 08/Mar/16 5:27 PM ]|
Thanks Bozhidar - I expect this will get updated for Clojure 1.9.
On the note in the change in method urls, the clojure.java.javadoc/javadoc function only builds urls to classes, not to methods, so I don't think that note has any impact on the patch.