<< Back to previous view

[CLJ-234] Adding provenance of deprecation warnings to the LispReader Created: 01/Jan/10  Updated: 01/Mar/13  Resolved: 31/Dec/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.3

Type: Enhancement Priority: Minor
Reporter: Assembla Importer Assignee: Unassigned
Resolution: Declined Votes: 0
Labels: None

Attachments: Text File 0234_LispReader_deprecation_provenance.patch     Text File 0234_LispReader_deprecation_provenance.patch    
Approval: Vetted


The LispReader has some deprecation warnings, but they do not show their provenance. The attached patch provide improved warning messages by modifying the LineNumberingPushbackReader to include the source path of the file being read, so that it can be retrieved by the LispReader.

Comment by Assembla Importer [ 28/Sep/10 7:02 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/234
0002-Modified-the-LineNumberingPushbackReader-to-include-.patch - https://www.assembla.com/spaces/clojure/documents/bmHcpC9Yur3RGweJe5afGb/download/bmHcpC9Yur3RGweJe5afGb

Comment by Stuart Halloway [ 17/Dec/10 2:31 PM ]

Alan: please bounce this if incomplete, or screen if it seems simple enough.

Comment by Alan Dipert [ 17/Dec/10 2:53 PM ]

The patch looks good, but as of 1.2 there are no longer any deprecated reader macros. This might be worth adding in case any macros are deprecated in the future.

Comment by Stuart Halloway [ 31/Dec/10 3:59 PM ]

If we ever have another deprecation, we should bring this back along with a test case.

Generated at Sat Jan 20 03:38:42 CST 2018 using JIRA 4.4#649-r158309.