<< Back to previous view

[CLJ-842] clojure.pprint uses the old-style metadata. Created: 26/Sep/11  Updated: 21/Jul/15

Status: Open
Project: Clojure
Component/s: None
Affects Version/s: Release 1.3
Fix Version/s: None

Type: Enhancement Priority: Minor
Reporter: Baishampayan Ghose Assignee: Unassigned
Resolution: Unresolved Votes: 0
Labels: print

Attachments: Text File 0001-Migrate-the-metadata-in-clojure.pprint.-to-the-new-s.patch     Text File clj-842-update-clojure.pprint-metadata-v2.txt    
Patch: Code


I was looking through the implementation of clojure.pprint.* and found that it still uses the old-style metadata to mark vars as private - ^{:private true} instead of ^:private.

I have migrated the metadata to the new style in the attached trivial patch, which can be used in case this is deemed to be an issue.

FWIW, there are some other namespaces which use the old-style metadata as well; I am willing to fix those as well.

Comment by Andy Fingerhut [ 14/Nov/12 1:19 PM ]

clj-842-update-clojure.pprint-metadata-v2.txt dated Nov 14 2012 is identical to Baishampayan Ghose's 0001-Migrate-the-metadata-in-clojure.pprint.-to-the-new-s.patch dated Sep 26, 2011, except it applies cleanly to latest master.

Comment by Stuart Halloway [ 21/Jul/15 1:27 PM ]

Recategorizing as enhancement since the old form continues to be legal.

Generated at Tue Feb 19 04:42:12 CST 2019 using JIRA 4.4#649-r158309.