<< Back to previous view

[CLJ-96] GC Issue 92: Check for key identity in collections Created: 17/Jun/09  Updated: 24/Aug/10  Resolved: 24/Aug/10

Status: Closed
Project: Clojure
Component/s: None
Affects Version/s: None
Fix Version/s: Release 1.2

Type: Enhancement
Reporter: Anonymous Assignee: Christophe Grand
Resolution: Completed Votes: 0
Labels: None

Approval: Ok

 Description   
Reported by chouser, Mar 09, 2009

Describe the feature/change.

Clojure code routes key lookups through
clojure.lang.Util.equiv()/equals(), which do an identity check.

Using the collections from outside Clojure may to more expensive
comparisons even on identical objects, so each collection should also
do an identity check.

Was this discussed on the group? If so, please provide a link to the
discussion:

http://groups.google.com/group/clojure/msg/6a2e491fcf564a68


 Comments   
Comment by Assembla Importer [ 24/Aug/10 6:45 AM ]

Converted from http://www.assembla.com/spaces/clojure/tickets/96
Attachments:
0001-Check-for-identity-before-equality-in-.equals-for-co.patch - https://www.assembla.com/spaces/clojure/documents/ch_3rOrUir36rbeJe5d-aX/download/ch_3rOrUir36rbeJe5d-aX

Comment by Assembla Importer [ 24/Aug/10 6:45 AM ]

richhickey said: Updating tickets (#8, #19, #30, #31, #126, #17, #42, #47, #50, #61, #64, #69, #71, #77, #79, #84, #87, #89, #96, #99, #103, #107, #112, #113, #114, #115, #118, #119, #121, #122, #124)

Comment by Assembla Importer [ 24/Aug/10 6:45 AM ]

richhickey said: Updating tickets (#8, #42, #113, #2, #20, #94, #96, #104, #119, #124, #127, #149, #162)

Comment by Assembla Importer [ 24/Aug/10 6:45 AM ]

richhickey said: Updating tickets (#94, #96, #104, #119, #163)

Comment by Assembla Importer [ 24/Aug/10 6:45 AM ]

cgrand said: [file:ch_3rOrUir36rbeJe5d-aX]: patch

Comment by Assembla Importer [ 24/Aug/10 6:45 AM ]

cgrand said: Add identity check to .equals in gvec, ASeq, APersistentVector, APersistentSet and APersistentMap.

Comment by Assembla Importer [ 24/Aug/10 6:45 AM ]

cgrand said: (In [[r:ee9fc81dd2ef15d7ea3e17e7ec2370c5c09d633e]]) Check for identity before equality in .equals for collections, see #96

Signed-off-by: Stuart Halloway <stu@thinkrelevance.com>

Branch: master

Generated at Wed Oct 17 11:50:34 CDT 2018 using JIRA 4.4#649-r158309.