<< Back to previous view

[CLJS-438] copy cond-> etc from 1.5 Created: 11/Dec/12  Updated: 27/Jul/13  Resolved: 17/Mar/13

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Major
Reporter: Tom Jack Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File CLJS-438_2012-03-16.patch     Text File cljs-438-condetc.patch    
Patch: Code


Attached patch (cljs-438-condetc.patch, 11 Dec 2012) copies cond->, cond->>, as->, some->, and some->> from 1.5 master. This lets ClojureScript users use these macros without requiring Clojure 1.5.

I suppose this maybe should wait until 1.5.0 is out, in case another renaming occurs.

Another way to do this would be to have import-macros ignore missing macros and add these there. Then the macros would only be available for users requiring Clojure 1.5 (which.. makes sense), and we wouldn't have to copy them.

Comment by David Nolen [ 22/Dec/12 2:32 PM ]

I'm inclined to hold off on this one since 1.5 is so close. As soon as 1.5 becomes official I'd like to make it a requirement for ClojureScript - as then I can merge the source-map branch and hopefully get some help on that work.

Comment by Tom Jack [ 22/Dec/12 11:25 PM ]

Sounds good.

Comment by David Nolen [ 20/Feb/13 8:42 AM ]

Is this patch up-to-date? Seems like 1.5 is just around the corner.

Comment by David Nolen [ 01/Mar/13 1:28 PM ]

Can we get an updated version of this patch that applies to master? Thanks!

Comment by Tom Jack [ 03/Mar/13 12:28 PM ]

You want the patch as is, copying the macros from 1.5? I assumed we'd move to 1.5 and then we can just add cond-> etc to the import-macros call.

Comment by Tom Jack [ 16/Mar/13 2:10 PM ]

Here's the patch I think you want. It applies to master and assumes 1.5. (CLJS-438_2012-03-16.patch)

Comment by David Nolen [ 17/Mar/13 3:01 PM ]

fixed, http://github.com/clojure/clojurescript/commit/f311159889e66f7029e41ae5f61fda9ac3779643

Generated at Fri Sep 22 15:41:44 CDT 2017 using JIRA 4.4#649-r158309.