<< Back to previous view

[CLJS-545] Symbols should use caching-hash; also, nil as initial value Created: 19/Jul/13  Updated: 29/Jul/13  Resolved: 29/Jul/13

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Minor
Reporter: MichaƂ Marczyk Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Attachments: Text File 0001-CLJS-545-use-caching-hash-in-cljs.core.Symbol.patch    


Currently cljs.core.Symbol uses its own implementation of hash caching, even though it could use the caching-hash macro. To use the macro it would have to use nil rather than the current -1 as the initial value, but that's a feature (no reason to use a magic value in ClojureScript). Also, a private function for hashing symbols would be needed (but the whole thing still feels simpler).

The forthcoming patch makes the changes described above.

Comment by David Nolen [ 29/Jul/13 11:15 PM ]

fixed http://github.com/clojure/clojurescript/commit/0e975078575fbd8617a7561b69f8c1757e3554cb

Generated at Thu Jan 18 23:42:26 CST 2018 using JIRA 4.4#649-r158309.