<< Back to previous view

[CLJS-546] Speed up PersistentVector's conj Created: 24/Jul/13  Updated: 19/Nov/13  Resolved: 19/Nov/13

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Enhancement Priority: Major
Reporter: Michał Marczyk Assignee: Michał Marczyk
Resolution: Completed Votes: 0
Labels: None


Jozef Wagner's comparative benchmarking of PVs and core.rrb-vector has uncovered a rather fascinating fact that PV's conj is significantly slower in Chrome and only slightly faster in Firefox. This won't do at all. The obvious approach to fixing the issue doesn't seem to make any difference in my pure V8 benchmarking, so now I'll have to look into this more closely.

At any rate, a patch changing PVs to use core.rrb-vector-like conj logic is forthcoming (after some extra tests on my end).

Comment by David Nolen [ 19/Nov/13 9:17 PM ]

We're in shooting distance of Clojure on the JVM with respect to PV conj now.

Generated at Mon Jan 22 14:35:06 CST 2018 using JIRA 4.4#649-r158309.