<< Back to previous view

[CLJS-628] *cljs-file* not bound when compiling from file to stdout Created: 18/Oct/13  Updated: 24/Oct/13  Resolved: 24/Oct/13

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Travis Thieman Assignee: Unassigned
Resolution: Completed Votes: 0
Labels: None

Attachments: File cljs-file-20131018.diff    
Patch: Code


The compile-file function in closure.clj branches on whether an output file is specified. If one is not, the else branch executes compile-form-seq, which does not bind analyzer/cljs-file to the current input filename. This makes the file information unavailable for error descriptions downstream. When compiling to an output file, analyzer/cljs-file is bound within compiler/compile-file*, so this is only a problem when compiling to stdout.

This patch binds analyzer/cljs-file to the input file when outputting to stdout or any otehr non-file target.

Comment by David Nolen [ 24/Oct/13 9:05 AM ]

fixed, https://github.com/clojure/clojurescript/commit/0d6d293c0ccb1a3c435b9c1569c5610b30016b73

Generated at Sun Sep 24 12:41:32 CDT 2017 using JIRA 4.4#649-r158309.