<< Back to previous view

[CLJS-744] ISequential types should implement JS indexOf, lastIndexOf Created: 05/Jan/14  Updated: 15/Feb/16  Resolved: 15/Feb/16

Status: Closed
Project: ClojureScript
Component/s: None
Affects Version/s: 1.7.145
Fix Version/s: 1.9.76

Type: Defect Priority: Minor
Reporter: David Nolen Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: newbie

Attachments: Text File CLJS-744-1.patch     Text File CLJS-744-2.patch     Text File CLJS-744-3.patch     Text File CLJS-744.patch     Text File CLJS-744.patch    
Patch: Code and Test


added cljs-744-3.patch which cleans whitespace

Comment by António Nuno Monteiro [ 14/Feb/16 10:47 AM ]

I'm working on a patch for this issue. Assigned to myself.

Comment by António Nuno Monteiro [ 14/Feb/16 6:09 PM ]

submitted patch with code & tests; the most recent one should be considered, includes updated commit message

Comment by Andrea Richiardi [ 14/Feb/16 9:37 PM ]

Fix whitespace error so that the new patch applies cleanly.

Comment by António Nuno Monteiro [ 15/Feb/16 6:00 AM ]

Found an edge case, working on an update to the patch. Not ready to apply yet.

Comment by António Nuno Monteiro [ 15/Feb/16 6:39 AM ]

attached updated patch `CLJS-744-2.patch`

Comment by David Nolen [ 15/Feb/16 3:55 PM ]

fixed https://github.com/clojure/clojurescript/commit/70a43138844e19f771ef20bc6e847829ce0a5711

Generated at Sat Jan 20 01:33:16 CST 2018 using JIRA 4.4#649-r158309.