[CLJS-774] cljs.reader should js js/parseInt with radix specified Created: 27/Feb/14 Updated: 12/Mar/14 Resolved: 12/Mar/14
In cljs.reader, the parse-int calls js/parseInt without a radix.
The radix is implementation defined if not specified.
This makes reading timestamps fail. For example:
in js console:
|Comment by Francis Avila [ 27/Feb/14 10:38 PM ]|
Discovered integer-with-radix parsing problem but split it into
This patch should fix ratio and inst parsing, but I don't have access to a browser which infers octals in parseInt.
Existing tests are sufficient to catch this problem for #inst.
There are no ratio tests for reader at all currently, but since ratios are shaky ground in cljs anyway I didn't add any.
|Comment by Dave Della Costa [ 12/Mar/14 1:14 AM ]|
Just chiming in to mention that I have experienced this issue in Internet Explorer 8 and was going to submit a patch myself. Would be interested in getting this into the next version as for now we have a customized reader that we use to get past this.
|Comment by David Nolen [ 12/Mar/14 8:26 AM ]|