<< Back to previous view

[DZIP-1] tag= doesn't work with records Created: 03/Feb/12  Updated: 28/Apr/16  Resolved: 30/Mar/12

Status: Closed
Project: data.zip
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Justin Kramer Assignee: Aaron Bedra
Resolution: Completed Votes: 1
Labels: None

Attachments: Text File 0001-fix-clojure.data.zip.xml-tag-to-work-with-records.patch    
Patch: Code and Test
Approval: Ok


clojure.data.zip.xml/tag= throws when given a record instead of a map, even if it has fields for tag, attrs, and content. Reason: tag= calls (node :tag) instead of (:tag node).

This was uncovered while trying to use data.zip with Ryan Senior's new data.xml, which produces Element records.

Patch with fix and test attached.

Comment by Aaron Bedra [ 30/Mar/12 4:08 PM ]

Thanks! I just gave it quick once over and I think it should cover things nicely. I will take a closer look this evening and if things are proper i'll cut a new version and release right away. This is an issue that bit me just last week that I never got around to reporting.

Comment by Aaron Bedra [ 30/Mar/12 4:48 PM ]

This has been committed and a release 0.1.1 has been pushed. It is staged to Sonatype now and should hit Maven Central within a few hours.

Comment by Alex Miller [ 28/Apr/16 10:55 AM ]

applied long time ago, closing

Generated at Wed Oct 18 09:36:18 CDT 2017 using JIRA 4.4#649-r158309.