<< Back to previous view

[JDBC-85] Two unit tests do not test anything Created: 23/Dec/13  Updated: 01/Jun/16  Resolved: 23/Dec/13

Status: Closed
Project: java.jdbc
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Andy Fingerhut Assignee: Sean Corfield
Resolution: Completed Votes: 0
Labels: None

Attachments: File jdbc-85-v1.diff    


The following two unit tests are of the form (is (= expr1) expr2), which can never fail, because (= expr1) is always true.

(is (= :K_W) (sql/as-keyword :K_W))
    (is (= :k.w) (sql/as-keyword :k.w))))

Found using a pre-release version of the Eastwood Clojure lint tool.

Comment by Andy Fingerhut [ 23/Dec/13 6:18 PM ]

Patch jdbc-85-v1.diff simply shuffles around the parens so that the tests are of the probably-intended form (is (= expr1 expr2))

Comment by Sean Corfield [ 23/Dec/13 6:27 PM ]

Thanx Andy!

Comment by Sean Corfield [ 23/Dec/13 6:37 PM ]

Patch applied.

Generated at Thu Jan 18 06:07:55 CST 2018 using JIRA 4.4#649-r158309.