<< Back to previous view

[LOGIC-122] Subpattern {?x (?y ?y)} fails to unify Created: 15/Mar/13  Updated: 28/Jul/13  Resolved: 17/Mar/13

Status: Closed
Project: core.logic
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Major
Reporter: Jonas Enlund Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None

Attachments: File LOGIC-120-121-122-squashed.diff     File LOGIC-122.diff    


This expression should unify but doesn't:

(unify {:as '{?x (?y ?y)}} '[[?y ?x] [1 (1 1)]])

Comment by Jonas Enlund [ 16/Mar/13 2:35 AM ]

The patch LOGIC-122.diff includes patches for LOGIC-120 and LOGIC-121

Comment by David Nolen [ 16/Mar/13 9:18 AM ]

So unless I'm mistaken I only need to apply this patch to address the three tickets correct?

Comment by Jonas Enlund [ 16/Mar/13 9:56 AM ]

Correct. This patch fixes LOGIC-120 121 and 122. The patch for LOGIC-118 is not included in these commits. Do you want tests in a seperate ticket/patch?

Comment by David Nolen [ 16/Mar/13 10:50 AM ]

I would actually prefer a squashed patch that includes the tests. Thanks. It makes sense to deal with LOGIC-118 separately, can we make sure we have tests there as well? Thanks!

Comment by Jonas Enlund [ 16/Mar/13 11:07 AM ]

Use LOGIC-120-121-122-squashed.diff. It includes the tests.

Comment by David Nolen [ 17/Mar/13 11:39 AM ]

fixed http://github.com/clojure/core.logic/commit/2bf23fd1ea64966bae094c9f634dfb21ddd386d1

Generated at Mon Jan 22 12:33:38 CST 2018 using JIRA 4.4#649-r158309.