<< Back to previous view

[LOGIC-150] deftest test-root-1 in namespace clojure.core.logic.tests missing 'is'? Created: 15/Dec/13  Updated: 20/Dec/13  Resolved: 20/Dec/13

Status: Closed
Project: core.logic
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Andy Fingerhut Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None

Attachments: File logic-150-v1.diff    


The two = expressions in deftest test-root-1 should probably be wrapped in (is ...):

(deftest test-root-1 []
  (let [x (lvar 'x)
        s (ext-no-check empty-s x 1)]
    (= (root-var s x) x)
    (= (root-val s x) 1)))

Found while testing next version of Eastwood linter on a bunch of projects. It warned that the first (= ...) expression's return value was unused.

Comment by Andy Fingerhut [ 16/Dec/13 3:52 AM ]

Patch logic-150-v1.diff fixes the issue in the ticket description, and a few other minor ones also found by the Eastwood Clojure lint tool.

Comment by David Nolen [ 20/Dec/13 12:19 PM ]

fixed, https://github.com/clojure/core.logic/commit/5bf5147afdb0fe04da658c3573ca63a922975d05

Generated at Sun Sep 24 07:11:27 CDT 2017 using JIRA 4.4#649-r158309.