<< Back to previous view

[MATCH-91] One unit test always passes without testing anything Created: 23/Dec/13  Updated: 30/Dec/13  Resolved: 30/Dec/13

Status: Closed
Project: core.match
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Trivial
Reporter: Andy Fingerhut Assignee: David Nolen
Resolution: Completed Votes: 0
Labels: None

Attachments: File match-91-v1.diff    


This test is incorrectly parenthesized. It has the structure (is (= expr1) expr2), which always passes:

(deftest vector-rest-pattern-1
  (is (= (match [[:plus 1 2 3]]
           [[:pow arg pow]] 0
           [[:plus & args]] 1
           :else 2))

Another test named match-differing-patterns is repeated verbatim twice.

Comment by Andy Fingerhut [ 23/Dec/13 5:34 PM ]

Patch match-91-v1.diff fixes both of the issues mentioned in the description.

Comment by David Nolen [ 30/Dec/13 7:18 PM ]

fixed https://github.com/clojure/core.match/commit/e3d2c9dff4645833c851fc366a6b7876c194a8f4

Generated at Sat Sep 23 04:20:46 CDT 2017 using JIRA 4.4#649-r158309.