[JDBC-156] Incorrect connection-uri spec Created: 13/Sep/17 Updated: 13/Sep/17 Resolved: 13/Sep/17
|Reporter:||Ikuru Kanuma||Assignee:||Sean Corfield|
:connection-uri needs to be a String(based on implementation + doc).
However, the spec for connection-uri is defined as (s/def ::connection-uri #(instance? java.net.URI %)) .
(require '[clojure.java.jdbc :as db])
|Comment by Ikuru Kanuma [ 13/Sep/17 9:59 PM ]|
Confirmed that the attached patch resolves the issue
|Comment by Sean Corfield [ 13/Sep/17 9:59 PM ]|
Good catch! Thank you! Will be in 0.7.2.
|Comment by Sean Corfield [ 13/Sep/17 10:02 PM ]|
I changed the spec to just string? which is more idiomatic than checking instance? java.lang.String.
|Comment by Ikuru Kanuma [ 13/Sep/17 10:05 PM ]|
Sounds good! Thanks for the quick response.