<< Back to previous view

[NREPL-84] Log "foo" for (misc/log "foo"), not nil Created: 20/Apr/17  Updated: 21/Apr/17

Status: Open
Project: tools.nrepl
Component/s: None
Affects Version/s: None
Fix Version/s: None

Type: Defect Priority: Minor
Reporter: Rob Browning Assignee: Chas Emerick
Resolution: Unresolved Votes: 0
Labels: None

Attachments: Text File 0001-misc-log-print-foo-not-nil-in-log-foo-output.patch    
Patch: Code


Previously (log "foo") would just convert any first argument that wasn't a Throwable to nil, whereas clojure.tools.logging/log would log "foo".

Comment by Chas Emerick [ 20/Apr/17 11:14 AM ]

Looks fine to me. However, before I can apply the patch, you'll need to execute a contributor agreement, linked here:


Comment by Alex Miller [ 20/Apr/17 9:19 PM ]

Rob has signed the CA and is on the contributors list at https://clojure.org/community/contributors

Comment by Chas Emerick [ 21/Apr/17 7:02 AM ]

Ach, I searched on https://clojure.org/community/contributing, not noticing that the list of names there are of prior contributors, not CA signers. Thanks, Alex, I'll try reading next time!

Will apply the patch shortly.

Generated at Mon Apr 24 00:55:10 CDT 2017 using JIRA 4.4#649-r158309.